fix: rewrite onTextChanged to onSelectionChanged event handler in KeyboardAwareScrollView
#546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirillzyusko
added
🐛 bug
📊 Package size report
|
kirillzyusko
force-pushed
the
fix/keyboard-aware-scroll-view-rewrite-text-changed-to-text-selection
branch
from
cfe7be3 to
8783c80
Compare
kirillzyusko
force-pushed
the
fix/keyboard-aware-scroll-view-rewrite-text-changed-to-text-selection
branch
2 times, most recently
from
97d5f90 to
0d2bc42
Compare
kirillzyusko
force-pushed
the
fix/keyboard-aware-scroll-view-rewrite-text-changed-to-text-selection
branch
from
b9bfc09 to
d8d8f34
Compare
… `KeyboardAwareScrollView`
kirillzyusko
force-pushed
the
fix/keyboard-aware-scroll-view-rewrite-text-changed-to-text-selection
branch
from
d8d8f34 to
f802462
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Do
looks like<-- revert assetsuseAnimatedReactionon iOS doesn't work (FirstInputGrownimage has changed);Android - when scroll back disabled it still scrollsAndroid - when we type1we still have the same image as before - theoretically padding should be reduced.flaky Android scrolling<- fixed in e2eflaky<- fixed viaFirstInputGrownclampAndroid - TextInput after text change too close to keyboarduseAnimatedReactionand we scroll based onlayout📜 Description
💡 Motivation and Context
Closes #512
📢 Changelog
JS
iOS
Android
🤔 How Has This Been Tested?
📸 Screenshots (if appropriate):
📝 Checklist